BRND Booking #313
BRND Booking #313
Conversation
agnetemoos
force-pushed
the
feature/brnd-feed
branch
from
3b9835f to
e2b4b67
Compare
| ], | ||
| 'api_auth_key' => [ | ||
| 'type' => 'string', | ||
| 'exposeValue' => true, |
There was a problem hiding this comment.
I think you should hide this value, otherwise everybody in the admin can see the value.
| 'exposeValue' => true, | |
| 'exposeValue' => false, |
It will still be possible to set the value, it will just not be visible in the admin after being set.
|
|
||
| $bookings = $this->apiClient->getInfomonitorBookingsDetails($feedSource, $sportCenterId); | ||
|
|
||
| $result['bookings'] = array_map([$this, 'parseBrndBooking'], $bookings); |
There was a problem hiding this comment.
I think you need to filter out entries that do not meet some minimum requirements (startTime, endTime, activity, ?)
Otherwise, you can end up with slides that display broken data.
I would replace array_map with array_reduce and add some validation checks and ignore broken entries.
| $startDateTime = null; | ||
| if (!empty($booking['dato']) && isset($booking['starttid']) && is_string($booking['starttid'])) { | ||
| // Trim starttid to 6 digits after dot for microseconds | ||
| $starttid = preg_replace('/\.(\d{6})\d+$/', '.$1', $booking['starttid']); |
There was a problem hiding this comment.
Replace danish variable name with english.
Maybe: $startTimeString
| // Parse end time | ||
| $endDateTime = null; | ||
| if (!empty($booking['dato']) && isset($booking['sluttid']) && is_string($booking['sluttid'])) { | ||
| $sluttid = preg_replace('/\.(\d{6})\d+$/', '.$1', $booking['sluttid']); |
There was a problem hiding this comment.
Replace danish variable name with english.
Maybe: $endTimeString
| $starttid = preg_replace('/\.(\d{6})\d+$/', '.$1', $booking['starttid']); | ||
| $dateOnly = substr($booking['dato'], 0, 10); | ||
| $dateTimeString = $dateOnly.' '.$starttid; | ||
| $startDateTime = \DateTimeImmutable::createFromFormat('m/d/Y H:i:s.u', $dateTimeString); |
There was a problem hiding this comment.
What if this throws an exception or returns false?
https://www.php.net/manual/en/datetime.createfromformat.php
| $sluttid = preg_replace('/\.(\d{6})\d+$/', '.$1', $booking['sluttid']); | ||
| $dateOnly = substr($booking['dato'], 0, 10); | ||
| $dateTimeString = $dateOnly.' '.$sluttid; | ||
| $endDateTime = \DateTimeImmutable::createFromFormat('m/d/Y H:i:s.u', $dateTimeString); |
There was a problem hiding this comment.
What if this throws an exception or returns false?
https://www.php.net/manual/en/datetime.createfromformat.php
| ]; | ||
| } | ||
|
|
||
| public function getData(Feed $feed): array |
There was a problem hiding this comment.
Make sure this function does not throw an exception.
It should always return $result, so the client does not have to handle the exceptions.
2 participants
Link to ticket
Fixes #309
Description
Add BRND Booking feed type